Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to set Port value out of accepted range. #575

Closed
jurijakimuk opened this issue Mar 28, 2019 · 4 comments
Closed

Able to set Port value out of accepted range. #575

jurijakimuk opened this issue Mar 28, 2019 · 4 comments
Assignees
@echoby
Labels
bug Something isn't working ux ux/ui issues or inconsistencies
Projects
Bright Boson 2.1

Comments

@jurijakimuk
Copy link

jurijakimuk commented Mar 28, 2019 •
edited

Bug description
In the Setup Node Conectivity screen currently it's possible to enter a port value more than 65535. We must not allow users to enter value out of this range 1 - 65535.
!!! Edited: The range must be 1 - 65535 !!! (not 0 - 65535)

To Reproduce

  1. Start creating a wallet.
  2. Proceed until the Setup Node Conectivity screen is on.
  3. In the Run Integrated Node field enter a value more than 65535.

Current behaviour
User is able to enter a higher value than the right edge.

Expected behaviour
User is NOT able to enter a higher value than the right edge. Maximum possible port number to enter is 65535.

Notes:
Currently if the user enters port number higher than allowed, e.g. "88000" - then later there can be a problem switching to the remote node from local node in the app settings.

Screenshots
Add screenshots that illustrate a problem you've found.
image
@jurijakimuk jurijakimuk added bug Something isn't working ux ux/ui issues or inconsistencies labels Mar 28, 2019
@gingervik gingervik added this to To do in Desktop wallet improvements via automation Mar 28, 2019
@echoby echoby closed this as completed in 1334358 Apr 10, 2019
echoby added a commit that referenced this issue Apr 10, 2019
@echoby
Merge pull request #597 from jonathancross/max-port-num
2d0940f 
 Disallow bad port numbers. Fixes #575
@echoby echoby reopened this Apr 10, 2019
@echoby echoby added this to To do in Bright Boson 2.1 via automation Apr 10, 2019
@echoby echoby moved this from To do to Done in Bright Boson 2.1 Apr 10, 2019
@gingervik gingervik assigned jurijakimuk and unassigned anatolse Apr 10, 2019
@jurijakimuk
Copy link
Author

OK on master, 4725.

Bright Boson 2.1 automation moved this from Done to Tested Apr 10, 2019
@jurijakimuk jurijakimuk reopened this Apr 10, 2019
Bright Boson 2.1 automation moved this from Tested to To do Apr 10, 2019
@jurijakimuk
Copy link
Author

Looks like port 0 is not acceptable.
The wallet is offline in this case. Minimal port number allowed must be 1.
Please,

  1. Do not allow entering of 0 as a port number.
  2. Fix the message "Port must be a number between 0 and 65535" to "Port must be a number between 1 and 65535".
    @echoby Thank you

@jurijakimuk jurijakimuk assigned echoby and unassigned jurijakimuk Apr 10, 2019
echoby added a commit that referenced this issue Apr 10, 2019
@echoby
#575 exclude 0 from allowed ports range
1fcc443
@echoby echoby moved this from To do to Done in Bright Boson 2.1 Apr 10, 2019
@jurijakimuk
Copy link
Author

jurijakimuk commented Apr 10, 2019 •
edited

Please, add the same validation on the Settings screen in these 3 places. Allowed ports are 1 - 65535. Thank you.
image

@jurijakimuk jurijakimuk moved this from Done to To do in Bright Boson 2.1 Apr 10, 2019
@echoby echoby moved this from To do to In progress in Bright Boson 2.1 Apr 15, 2019
echoby added a commit that referenced this issue Apr 16, 2019
@echoby
#575 disable 0 port value in settings
c400412
@echoby echoby moved this from In progress to Done in Bright Boson 2.1 Apr 16, 2019
@Sergei-Beam
Copy link
Member

checked

Bright Boson 2.1 automation moved this from Done to Tested Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echoby echoby

Labels
bug Something isn't working ux ux/ui issues or inconsistencies
Projects
No open projects
Bright Boson 2.1
  
Tested
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anatolse @echoby @jurijakimuk @Sergei-Beam