Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print out user-friendly error message when payment proof is not provided #491

Closed
jurijakimuk opened this issue Feb 25, 2019 · 2 comments
Closed

Print out user-friendly error message when payment proof is not provided #491

jurijakimuk opened this issue Feb 25, 2019 · 2 comments
Assignees
@Sergei-Beam
Labels
cli Issues related to CLI Wallet task Something new to develop
Projects
Bright Boson 2.1

Comments

@jurijakimuk
Copy link

jurijakimuk commented Feb 25, 2019 •
edited

Bug description
In CLI wallet when user wants to verify the payment proof, but doesn't provide the payment proof, then no user-friendly error is printed out.

To Reproduce
Steps to reproduce the behaviour:

  1. Run beam-wallet payment_proof_verify.

Current behaviour
The error message is printed out: boost::bad_any_cast: failed conversion using boost::any_cast.

Expected behaviour
The error message is printed out (text may vary, it's not specified): No payment proof provided: --payment-proof parameter is missing.

Platform and build

  • Windows
  • 10 x64
  • 4402, master

Screenshots (if applicable)
image
@jurijakimuk jurijakimuk added task Something new to develop cli Issues related to CLI Wallet labels Feb 25, 2019
@jurijakimuk jurijakimuk added this to To Do in Backlog via automation Feb 25, 2019
@jurijakimuk jurijakimuk changed the title Print out user-friendly error message when not specifying payment proof for verification Print out user-friendly error message when payment proof is not provided Feb 25, 2019
@sasha-abramovich sasha-abramovich removed this from To Do in Backlog Mar 25, 2019
@sasha-abramovich sasha-abramovich added this to To do in Bright Boson 2.1 via automation Mar 25, 2019
@anatolse anatolse assigned echoby and unassigned anatolse Apr 8, 2019
@echoby echoby moved this from To do to In progress in Bright Boson 2.1 Apr 16, 2019
echoby added a commit that referenced this issue Apr 16, 2019
@echoby
#491 Added error message when payment proof is not provided
f1b53bf
@echoby echoby moved this from In progress to Done in Bright Boson 2.1 Apr 16, 2019
@Sergei-Beam
Copy link
Member

@echoby Please change error message text to :
No payment proof provided: --payment_proof parameter is missing"
Because previous has the typo in the command --payment_proof
image

@Sergei-Beam Sergei-Beam moved this from Done to To do in Bright Boson 2.1 Apr 17, 2019
echoby added a commit that referenced this issue Apr 17, 2019
@echoby
#491 typo fixed
8504467
@echoby echoby moved this from To do to Done in Bright Boson 2.1 Apr 17, 2019
@Sergei-Beam Sergei-Beam assigned Sergei-Beam and unassigned echoby Apr 17, 2019
@Sergei-Beam
Copy link
Member

checked

Bright Boson 2.1 automation moved this from Done to Tested Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sergei-Beam Sergei-Beam

Labels
cli Issues related to CLI Wallet task Something new to develop
Projects
No open projects
Bright Boson 2.1
  
Tested
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anatolse @echoby @jurijakimuk @Sergei-Beam